Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure unique splash text on schedule change #554

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Samathingamajig
Copy link
Collaborator

@Samathingamajig Samathingamajig commented Mar 10, 2025

Before: swapping between multiple empty schedules shows the same splash text. It's jarring.

Screen.Recording.2025-03-10.at.2.35.32.PM.mov

After: swapping between multiple empty schedules show a new splash text every time. It's beautiful.

Screen.Recording.2025-03-10.at.2.41.13.PM.mov

This change is Reviewable

Copy link
Collaborator

@Preston-Cook Preston-Cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit 9448072 into main Mar 10, 2025
13 checks passed
@doprz doprz deleted the feat/shuffle-splash-text-when-switching-schedules branch March 10, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants